If Apple “created demand” for the iPhone, why can’t they replicate that success across all their products?

Because they can’t define the size and shape of demand! That’s my point.

There were pre-existing market conditions in the smartphone market that Apple benefitted from.